Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add armv5 support #113

Closed
wants to merge 6 commits into from
Closed

Conversation

jamesmunns
Copy link
Contributor

Hey @japaric, heres a PR to integrate my work on ARMv5. Please let me know if you have any questions.

The changes to cross source should prevent the need for a Cross.toml, however as jemalloc and unwind are not available, it is still necessary to define a Xargo.toml, and make changes to Cargo.toml (as well as main.rs in Rust >= 1.20.0). These are detailed in TARGET-NOTES.md.

@japaric
Copy link
Contributor

japaric commented Sep 20, 2017

@jamesmunns Thanks for the PR and sorry for not commenting earlier.

I'd prefer if the official target Just Worked and cross used that instead of creating a new target.

I think that the official target specification should be tweaked: the target does support atomic operations (the OS provides them) so max-atomic-width should be changed accordingly; it also seems reasonable to change the default allocator to system if jemalloc doesn't compile for the target (iirc, the default allocator will be changed to libc's anyways).

It's harder to make the case for abort = panic though; all the "std targets" support unwinding AFAIK and setting abort = panic means that you can't use the test crate either so you can't do unit testing. So, ideally, libunwind should be made work -- I don't know what the exact problems are in that case though; does the library not compile?

@jamesmunns
Copy link
Contributor Author

If rust-lang/rust#44978 is merged, this PR will no longer be necessary.

@homunkulus
Copy link
Contributor

☔ The latest upstream changes (presumably #132) made this pull request unmergeable. Please resolve the merge conflicts.

@jamesmunns
Copy link
Contributor Author

Closing as rust-lang/rust#44978 has merged 🎉

@jamesmunns jamesmunns closed this Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants